pleroma

commit: fa8de790dfbdb2cc7de212be4ecdd2823048ba8f
parent ba2ae5e40bbe98d20be083d331222a9aea8b61de
Author: Mark Felder <feld@feld.me>
Date:   Thu,  3 Oct 2024 10:19:10 -0400

Remove test superceded by logic change

We will not be inserting jobs that should be skipped due to updated_at

Diffstat:
M
test/pleroma/workers/poll_worker_test.exs
61
+++++++++++++++++++++----------------------------------------

1 file changed, 21 insertions(+), 40 deletions(-)
diff --git a/test/pleroma/workers/poll_worker_test.exs b/test/pleroma/workers/poll_worker_test.exs
@@ -53,51 +53,32 @@ defmodule Pleroma.Workers.PollWorkerTest do
     end
   end
 
-  describe "poll refresh" do
-    test "normal job" do
-      user = insert(:user, local: false)
-      question = insert(:question, user: user)
-      activity = insert(:question_activity, question: question)
-
-      PollWorker.new(%{"op" => "refresh", "activity_id" => activity.id})
-      |> Oban.insert()
-
-      expected_job_args = %{"activity_id" => activity.id, "op" => "refresh"}
-
-      assert_enqueued(args: expected_job_args)
-
-      with_mocks([
-        {
-          Pleroma.Web.Streamer,
-          [],
-          [
-            stream: fn _, _ -> nil end
-          ]
-        }
-      ]) do
-        [job] = all_enqueued(worker: PollWorker)
-        PollWorker.perform(job)
-
-        # Ensure updates are streamed out
-        assert called(Pleroma.Web.Streamer.stream(["user", "list", "public", "public:local"], :_))
-      end
-    end
-
-    test "when updated_at is after poll closing" do
-      poll_closed = DateTime.utc_now() |> DateTime.add(-86_400) |> DateTime.to_iso8601()
-      user = insert(:user, local: false)
-      question = insert(:question, user: user, closed: poll_closed)
-      activity = insert(:question_activity, question: question)
+  test "poll refresh" do
+    user = insert(:user, local: false)
+    question = insert(:question, user: user)
+    activity = insert(:question_activity, question: question)
 
-      PollWorker.new(%{"op" => "refresh", "activity_id" => activity.id})
-      |> Oban.insert()
+    PollWorker.new(%{"op" => "refresh", "activity_id" => activity.id})
+    |> Oban.insert()
 
-      expected_job_args = %{"activity_id" => activity.id, "op" => "refresh"}
+    expected_job_args = %{"activity_id" => activity.id, "op" => "refresh"}
 
-      assert_enqueued(args: expected_job_args)
+    assert_enqueued(args: expected_job_args)
 
+    with_mocks([
+      {
+        Pleroma.Web.Streamer,
+        [],
+        [
+          stream: fn _, _ -> nil end
+        ]
+      }
+    ]) do
       [job] = all_enqueued(worker: PollWorker)
-      assert {:cancel, :poll_finalized} == PollWorker.perform(job)
+      PollWorker.perform(job)
+
+      # Ensure updates are streamed out
+      assert called(Pleroma.Web.Streamer.stream(["user", "list", "public", "public:local"], :_))
     end
   end
 end