commit: f4e48bc53ee5ffeb9e7387219c0d46dc33d04521
parent 72fc41d89196dc76e6c2c1c6213e10cbaadd7d3c
Author: Mark Felder <feld@feld.me>
Date: Fri, 23 Feb 2024 11:12:10 -0500
Rename variable to make the worker retry logic easier to read
The boolean value matches the intent of the "last_attempt" variable name now
Diffstat:
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/changelog.d/gun_pool3.skip b/changelog.d/gun_pool3.skip
diff --git a/lib/pleroma/gun/connection_pool/worker_supervisor.ex b/lib/pleroma/gun/connection_pool/worker_supervisor.ex
@@ -18,10 +18,10 @@ defmodule Pleroma.Gun.ConnectionPool.WorkerSupervisor do
)
end
- def start_worker(opts, retry \\ false) do
+ def start_worker(opts, last_attempt \\ false) do
case DynamicSupervisor.start_child(__MODULE__, {Pleroma.Gun.ConnectionPool.Worker, opts}) do
{:error, :max_children} ->
- funs = [fn -> retry end, fn -> match?(:error, free_pool()) end]
+ funs = [fn -> last_attempt end, fn -> match?(:error, free_pool()) end]
if Enum.any?(funs, fn fun -> fun.() end) do
:telemetry.execute([:pleroma, :connection_pool, :provision_failure], %{opts: opts})