pleroma

commit: d4c77103d1fe5df9b2ea8bd3429a8fc0240645c1
parent 5f5109413840d6ebcbee632fb883ae27dc3b45f7
Author: Mark Felder <feld@feld.me>
Date:   Wed, 27 Dec 2023 15:27:37 -0500

Fix detection of user follower collection being private

We were overzealous with matching on a raw error from the object fetch that should have never been relied on like this. If we can't fetch successfully we should assume that the collection is private.

Building a more expressive and universal error struct to match on may be something to consider.

Diffstat:
M
lib/pleroma/web/activity_pub/activity_pub.ex
4
+---

1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/lib/pleroma/web/activity_pub/activity_pub.ex b/lib/pleroma/web/activity_pub/activity_pub.ex
@@ -1697,9 +1697,7 @@ defmodule Pleroma.Web.ActivityPub.ActivityPub do
            Fetcher.fetch_and_contain_remote_object_from_id(first) do
       {:ok, false}
     else
-      {:error, {:ok, %{status: code}}} when code in [401, 403] -> {:ok, true}
-      {:error, _} = e -> e
-      e -> {:error, e}
+      {:error, _} -> {:ok, true}
     end
   end