pleroma

commit: 9f79df75082cfc563ce7816a1839800aa22ec350
parent 27ec46814cfb5515b16727d36bb028b5634b6b5d
Author: Mark Felder <feld@feld.me>
Date:   Thu, 12 Jun 2025 21:28:58 -0700

Add test demonstrating public getting stripped from unlisted activity CC

Diffstat:
M
test/pleroma/web/activity_pub/publisher_test.exs
69
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

1 file changed, 69 insertions(+), 0 deletions(-)
diff --git a/test/pleroma/web/activity_pub/publisher_test.exs b/test/pleroma/web/activity_pub/publisher_test.exs
@@ -520,4 +520,73 @@ defmodule Pleroma.Web.ActivityPub.PublisherTest do
 
     assert decoded["cc"] == []
   end
+
+  test "retains public address in cc for unlisted activities" do
+    user = insert(:user)
+
+    activity =
+      insert(:note_activity,
+        user: user,
+        data_attrs: %{
+          "cc" => [@as_public],
+          "to" => [user.follower_address]
+        }
+      )
+
+    assert @as_public in activity.data["cc"]
+
+    # Call prepare_one without an explicit cc parameter (default in production)
+    prepared =
+      Publisher.prepare_one(%{
+        inbox: "https://remote.instance/users/someone/inbox",
+        activity_id: activity.id
+      })
+
+    # Parse the JSON to verify the cc field in the federated message
+    {:ok, decoded} = Jason.decode(prepared.json)
+
+    # The public address should be preserved in the cc field
+    # Currently this will fail because it's being removed
+    assert @as_public in decoded["cc"]
+
+    # For verification, also test with an explicit cc parameter
+    # to show the cc field is completely replaced
+    prepared_with_cc =
+      Publisher.prepare_one(%{
+        inbox: "https://remote.instance/users/someone/inbox",
+        activity_id: activity.id,
+        cc: ["https://example.com/specific/user"]
+      })
+
+    {:ok, decoded_with_cc} = Jason.decode(prepared_with_cc.json)
+
+    # Verify cc is completely replaced with the provided value
+    assert decoded_with_cc["cc"] == ["https://example.com/specific/user"]
+  end
+
+  test "public address in cc parameter is preserved" do
+    user = insert(:user)
+
+    activity =
+      insert(:note_activity,
+        user: user,
+        data_attrs: %{
+          "cc" => [@as_public, "https://example.org/users/other"],
+          "to" => [user.follower_address]
+        }
+      )
+
+    assert @as_public in activity.data["cc"]
+
+    prepared_with_public_cc =
+      Publisher.prepare_one(%{
+        inbox: "https://remote.instance/users/someone/inbox",
+        activity_id: activity.id,
+        cc: [@as_public]
+      })
+
+    {:ok, decoded_with_public_cc} = Jason.decode(prepared_with_public_cc.json)
+
+    assert @as_public in decoded_with_public_cc["cc"]
+  end
 end