pleroma

commit: 8f15000c0f4c81b27b3a7077092f1ba1b37da205
parent d2d07bfe4b9f1567c205a736e6e81e02d13598c1
Author: Mark Felder <feld@feld.me>
Date:   Wed,  7 Aug 2024 14:38:29 -0400

Do not require a cc field when validating an incoming Follow activity

The cc field is not required and the code was keeping the cc if it existed on an activity or replacing it with the default of an empty list when casting. If any Follow activity was received with a cc field, it would attempt to keep it.

This was noticed in !4208 where we would craft Follow requests with a cc value of nil.

Diffstat:
M
lib/pleroma/web/activity_pub/object_validators/follow_validator.ex
2
+-

1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/pleroma/web/activity_pub/object_validators/follow_validator.ex b/lib/pleroma/web/activity_pub/object_validators/follow_validator.ex
@@ -29,7 +29,7 @@ defmodule Pleroma.Web.ActivityPub.ObjectValidators.FollowValidator do
 
   defp validate_data(cng) do
     cng
-    |> validate_required([:id, :type, :actor, :to, :cc, :object])
+    |> validate_required([:id, :type, :actor, :to, :object])
     |> validate_inclusion(:type, ["Follow"])
     |> validate_inclusion(:state, ~w{pending reject accept})
     |> validate_actor_presence()