pleroma

commit: 72b3ec35f898b5eb2e69affee9c9569a8c2e0a0a
parent a0cdc4cf9e6ff7857bc8a9dce029cf5103be9831
Author: Lain Soykaf <lain@lain.com>
Date:   Tue,  3 Jan 2023 14:59:14 -0500

Fix warnings in tests, treat warnings as errors in CI.

The warnings revealed two bad tests, the code still worked but the test
didn't actually test for it. Activating this for CI to prevent issues
like these in the future.

Diffstat:
M
.gitlab-ci.yml
2
+-
M
test/pleroma/user/import_test.exs
1
-
M
test/pleroma/user_search_test.exs
1
-
M
test/pleroma/web/activity_pub/transmogrifier/emoji_react_handling_test.exs
2
+-
M
test/pleroma/web/mastodon_api/update_credentials_test.exs
4
+++-
M
test/test_helper.exs
1
+

6 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
@@ -85,7 +85,7 @@ unit-testing:
   script:
     - mix ecto.create
     - mix ecto.migrate
-    - mix test --cover --preload-modules
+    - mix test --cover --preload-modules --warnings-as-errors
   coverage: '/^Line total: ([^ ]*%)$/'
   artifacts:
     reports:
diff --git a/test/pleroma/user/import_test.exs b/test/pleroma/user/import_test.exs
@@ -3,7 +3,6 @@
 # SPDX-License-Identifier: AGPL-3.0-only
 
 defmodule Pleroma.User.ImportTest do
-  alias Pleroma.Repo
   alias Pleroma.Tests.ObanHelpers
   alias Pleroma.User
 
diff --git a/test/pleroma/user_search_test.exs b/test/pleroma/user_search_test.exs
@@ -3,7 +3,6 @@
 # SPDX-License-Identifier: AGPL-3.0-only
 
 defmodule Pleroma.UserSearchTest do
-  alias Pleroma.Repo
   alias Pleroma.User
   use Pleroma.DataCase
 
diff --git a/test/pleroma/web/activity_pub/transmogrifier/emoji_react_handling_test.exs b/test/pleroma/web/activity_pub/transmogrifier/emoji_react_handling_test.exs
@@ -65,7 +65,7 @@ defmodule Pleroma.Web.ActivityPub.Transmogrifier.EmojiReactHandlingTest do
     object = Object.get_by_ap_id(data["object"])
 
     assert object.data["reaction_count"] == 1
-    assert match?([[emoji, _]], object.data["reactions"])
+    assert match?([[^emoji, _]], object.data["reactions"])
   end
 
   test "it reject invalid emoji reactions" do
diff --git a/test/pleroma/web/mastodon_api/update_credentials_test.exs b/test/pleroma/web/mastodon_api/update_credentials_test.exs
@@ -375,7 +375,9 @@ defmodule Pleroma.Web.MastodonAPI.UpdateCredentialsTest do
           "pleroma_background_image" => new_background_oversized
         })
 
-      assert user_response = json_response_and_validate_schema(res, 413)
+      assert %{"error" => "File is too large"} == json_response_and_validate_schema(res, 413)
+
+      user = Repo.get(User, user.id)
       assert user.background == %{}
 
       clear_config([:instance, :upload_limit], upload_limit)
diff --git a/test/test_helper.exs b/test/test_helper.exs
@@ -1,6 +1,7 @@
 # Pleroma: A lightweight social networking server
 # Copyright © 2017-2022 Pleroma Authors <https://pleroma.social/>
 # SPDX-License-Identifier: AGPL-3.0-only
+Code.put_compiler_option(:warnings_as_errors, true)
 
 os_exclude = if :os.type() == {:unix, :darwin}, do: [skip_on_mac: true], else: []
 ExUnit.start(exclude: [:federated, :erratic] ++ os_exclude)