utils-std

commit: f812205d814e039ecf67ce5c429f879177a1e9d0
parent f97514b3cb85a263918877bbb96a170fa00b2165
Author: Haelwenn (lanodan) Monnier <contact@hacktivis.me>
Date:   Mon, 26 Aug 2024 08:40:01 +0200

Remove shellcheck

Haskell doesn't boostraps, and this seems unlikely to be fixed any time soon.

Somewhat of an alternative could be checkbashisms, which effectively also
checks against ksh-isms but not so sure about a Perl script extracted from
Debian devscripts[1].
Effectively I'd rather it be C/Shell/Lua so linting can be done right into
a just-bootstrapped system.

1: https://salsa.debian.org/debian/devscripts

Diffstat:
M
Makefile
1
-
M
README.md
1
-
M
configure
9
---------

3 files changed, 0 insertions(+), 11 deletions(-)
diff --git a/Makefile b/Makefile
@@ -47,7 +47,6 @@ check-libs: $(TEST_LIBS)
 
 .PHONY: lint
 lint: $(MAN1SO)
-	$(SHELLCHECK) ./configure ./test_functions.sh $(SCRIPTS)
 	$(MANDOC) -Tlint -Wunsupp,error,warning $(MAN1)
 	$(REUSE) lint --quiet
 
diff --git a/README.md b/README.md
@@ -17,7 +17,6 @@ Developed on Linux+musl, automatically tested on FreeBSD and NetBSD thanks to [S
 - (optional, test) bwrap: <https://github.com/containers/bubblewrap/> For safely overlaying false files on the root filesystem
 - (optional, test) [prysk](https://www.prysk.net/) (or [cram](https://bitheap.org/cram/) but it got abandonned)
 - (optional, lint) mandoc: <https://mdocml.bsd.lv/> For linting the manual pages
-- (optional, lint) shellcheck: <https://www.shellcheck.net/> For linting `./configure` and shell scripts
 
 ## Packaging
 - The `./configure` script isn't auto*hell based, you can pass it arguments via key-value arguments or environment variables
diff --git a/configure b/configure
@@ -21,7 +21,6 @@ Variables:
   MAKE=BIN
   M4=BIN
   MANDOC=BIN
-  SHELLCHECK=BIN
   GCOV=BIN
   CRAM=BIN
   REUSE=BIN
@@ -121,7 +120,6 @@ GCOV="${GCOV:-gcov}"
 CFLAGS="${CFLAGS:--g -O2 -DDEBUG}"
 M4="${M4:-m4}"
 MANDOC="${MANDOC:-mandoc}"
-SHELLCHECK="${SHELLCHECK:-shellcheck}"
 CRAM="${CRAM:-cram}"
 REUSE="${REUSE:-reuse}"
 
@@ -178,12 +176,6 @@ then
 	MANDOC="true"
 fi
 
-if ! check_cmd SHELLCHECK "$SHELLCHECK"
-then
-	echo 'Notice: Linting depending on shellcheck disabled'
-	SHELLCHECK="true"
-fi
-
 if ! check_cmd CRAM "$CRAM"
 then
 	echo "Notice: cram not found, trying prysk"
@@ -248,7 +240,6 @@ YACC = ${YACC}
 MAKE = ${MAKE}
 M4 = ${M4}
 MANDOC = ${MANDOC}
-SHELLCHECK = ${SHELLCHECK}
 MSGFMT = ${MSGFMT}
 DBG = ${DBG}
 GCOV = ${GCOV}