utils-std

commit: f2aad882c8abd73dbf260901fa098634db3b3386
parent 7c789f68fee9e54cc1ffdd68af15b27a08a94e06
Author: Haelwenn (lanodan) Monnier <contact@hacktivis.me>
Date:   Sun,  5 Oct 2025 14:52:35 +0200

cmd/mv: fix fd-leak

Diffstat:
M
cmd/mv.c
9
++++++++-

1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/cmd/mv.c b/cmd/mv.c
@@ -119,7 +119,12 @@ copy_file_unlink(struct named_fd srcdir,
 
 	if(auto_file_copy(in, out, src_status.st_size, 0) < 0) return -1;
 
-	return unlinkat(srcdir.fd, src, 0);
+	int err = 0;
+	err += close(in);
+	err += close(out);
+	err += unlinkat(srcdir.fd, src, 0);
+
+	return err;
 }
 
 static int
@@ -162,6 +167,8 @@ rename_dir_entries(struct named_fd srcdir, struct named_fd destdir)
 		}
 	}
 
+	closedir(dirsrc);
+
 	return 0;
 }