logo

qmk_firmware

custom branch of QMK firmware git clone https://anongit.hacktivis.me/git/qmk_firmware.git
commit: ec324af22eddff1f89f33a30c77a678b111c420c
parent 2c54ff3e63062e432b5f1b6d01789e565e227336
Author: Joel Challis <git@zvecr.com>
Date:   Mon, 21 Apr 2025 20:07:05 +0100

Add lint warning for empty url (#25182)


Diffstat:

Mlib/python/qmk/cli/lint.py11+++++++++++
1 file changed, 11 insertions(+), 0 deletions(-)

diff --git a/lib/python/qmk/cli/lint.py b/lib/python/qmk/cli/lint.py @@ -171,6 +171,14 @@ def _handle_invalid_features(kb, info): return ok +def _handle_invalid_config(kb, info): + """Check for invalid keyboard level config + """ + if info.get('url') == "": + cli.log.warning(f'{kb}: Invalid keyboard level config detected - Optional field "url" should not be empty.') + return True + + def _chibios_conf_includenext_check(target): """Check the ChibiOS conf.h for the correct inclusion of the next conf.h """ @@ -255,6 +263,9 @@ def keyboard_check(kb): # noqa C901 if not _handle_invalid_features(kb, kb_info): ok = False + if not _handle_invalid_config(kb, kb_info): + ok = False + invalid_files = git_get_ignored_files(f'keyboards/{kb}/') for file in invalid_files: if 'keymap' in file: