qmk_firmware

commit: 66780783c79ba8be38dcc0921b15ddd68827e97d
parent 6efb71d401cf842241514b7dc9d425d0c5ec4f41
Author: Drashna Jaelre <drashna@live.com>
Date:   Mon, 19 Feb 2024 16:36:28 -0800

[Bug] Fix pmw33xx sensor corruption on get-cpi call (#23116)


Diffstat:
M
drivers/sensors/pmw3360.c
3
+++

1 file changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/sensors/pmw3360.c b/drivers/sensors/pmw3360.c
@@ -15,6 +15,9 @@ uint16_t pmw33xx_get_cpi(uint8_t sensor) {
     }
 
     uint8_t cpival = pmw33xx_read(sensor, REG_Config1);
+    // In some cases (100, 900, 1700, 2500), reading the CPI corrupts the firmware and the sensor stops responding.
+    // To avoid this, we write the value back to the sensor, which seems to prevent the corruption.
+    pmw33xx_write(sensor, REG_Config1, cpival);
     return (uint16_t)((cpival + 1) & 0xFF) * PMW33XX_CPI_STEP;
 }