commit: 6b40fc989575fd52b3b9bf3e8d78d7fb4a6c7696
parent 9a97e0d196c879e41dcb8bda8bd8128a039bacdc
Author: Henry Jameson <me@hjkos.com>
Date: Tue, 21 Mar 2023 22:26:11 +0200
fixes
Diffstat:
4 files changed, 15 insertions(+), 19 deletions(-)
diff --git a/src/components/settings_modal/admin_tabs/instance_tab.js b/src/components/settings_modal/admin_tabs/instance_tab.js
@@ -14,7 +14,6 @@ library.add(
)
const InstanceTab = {
- data () {},
components: {
BooleanSetting,
ChoiceSetting,
diff --git a/src/components/settings_modal/helpers/boolean_setting.vue b/src/components/settings_modal/helpers/boolean_setting.vue
@@ -13,26 +13,25 @@
class="label"
>
<template v-if="backendDescription">
- {{ backendDescriptionLabel + ' ' }}
+ {{ backendDescriptionLabel }}
</template>
<template v-else>
<slot />
</template>
</span>
- {{ ' ' }}
- <ModifiedIndicator
- :changed="isChanged"
- :onclick="reset"
- />
- <ProfileSettingIndicator :is-profile="isProfileSetting" />
- <DraftButtons />
- <p
- v-if="backendDescriptionDescription"
- class="setting-description"
- >
- {{ backendDescriptionDescription + ' ' }}
- </p>
</Checkbox>
+ <ModifiedIndicator
+ :changed="isChanged"
+ :onclick="reset"
+ />
+ <ProfileSettingIndicator :is-profile="isProfileSetting" />
+ <DraftButtons />
+ <p
+ v-if="backendDescriptionDescription"
+ class="setting-description"
+ >
+ {{ backendDescriptionDescription + ' ' }}
+ </p>
</label>
</template>
diff --git a/src/components/settings_modal/helpers/draft_buttons.vue b/src/components/settings_modal/helpers/draft_buttons.vue
@@ -5,13 +5,13 @@
class="DraftButtons"
>
<Popover
+ v-if="$parent.isDirty"
trigger="hover"
:trigger-attrs="{ 'aria-label': $t('settings.commit_value_tooltip') }"
>
<template #trigger>
<button
- v-if="$parent.isDirty"
class="button button-default btn"
type="button"
:title="$t('settings.commit_value')"
@@ -27,13 +27,13 @@
</template>
</Popover>
<Popover
+ v-if="$parent.isDirty"
trigger="hover"
:trigger-attrs="{ 'aria-label': $t('settings.reset_value_tooltip') }"
>
<template #trigger>
<button
- v-if="$parent.isDirty"
class="button button-default btn"
type="button"
:title="$t('settings.reset_value')"
diff --git a/src/components/settings_modal/helpers/setting.js b/src/components/settings_modal/helpers/setting.js
@@ -1,4 +1,3 @@
-import Checkbox from 'src/components/checkbox/checkbox.vue'
import ModifiedIndicator from './modified_indicator.vue'
import ProfileSettingIndicator from './profile_setting_indicator.vue'
import DraftButtons from './draft_buttons.vue'
@@ -6,7 +5,6 @@ import { get, set } from 'lodash'
export default {
components: {
- Checkbox,
ModifiedIndicator,
DraftButtons,
ProfileSettingIndicator