commit: d5ae6bb50124f8320f2b492380480038c487a6d2
parent 51fb4995a5242c0edca09167cf8c4b050cf5a186
Author: Yen Chi Hsuan <yan12125@gmail.com>
Date: Tue, 3 May 2016 15:37:30 +0800
[utils] Add rationale for register_socks_protocols
Diffstat:
1 file changed, 2 insertions(+), 0 deletions(-)
diff --git a/youtube_dl/utils.py b/youtube_dl/utils.py
@@ -63,6 +63,8 @@ from .socks import (
def register_socks_protocols():
# "Register" SOCKS protocols
+ # In Python < 2.6.5, urlsplit() suffers from bug https://bugs.python.org/issue7904
+ # URLs with protocols not in urlparse.uses_netloc are not handled correctly
for scheme in ('socks', 'socks4', 'socks4a', 'socks5'):
if scheme not in compat_urlparse.uses_netloc:
compat_urlparse.uses_netloc.append(scheme)