commit: bda37489ac5c14d18b1bb4290f2a2931dc8728c9
parent: ed22f65b3cdd84be5face35d82f127fff6a6b077
Author: Eugen Rochko <eugen@zeonfederated.com>
Date: Wed, 5 Apr 2017 02:32:18 +0200
Remove PuSH subscriptions when delivery is answered with a 4xx error
Diffstat:
1 file changed, 1 insertion(+), 0 deletions(-)
diff --git a/app/workers/pubsubhubbub/delivery_worker.rb b/app/workers/pubsubhubbub/delivery_worker.rb
@@ -22,6 +22,7 @@ class Pubsubhubbub::DeliveryWorker
.headers(headers)
.post(subscription.callback_url, body: payload)
+ return subscription.destroy! if response.code > 299 && response.code < 500 && response.code != 429 # HTTP 4xx means error is not temporary, except for 429 (throttling)
raise "Delivery failed for #{subscription.callback_url}: HTTP #{response.code}" unless response.code > 199 && response.code < 300
subscription.touch(:last_successful_delivery_at)