logo

mastofe

My custom branche(s) on git.pleroma.social/pleroma/mastofe
commit: 8cf8ce4ac0c2fb8b9d820cbea018dbfeba48ceec
parent: 0f1b1d78b15bd779c3427d4275d45d3e34e0b2ef
Author: Sorin Davidoi <sorin.davidoi@gmail.com>
Date:   Wed,  7 Jun 2017 20:05:53 +0200

fix(components/autosuggest_textarea): Race condition regarding onBlur (#3631)


Diffstat:

Mapp/javascript/mastodon/components/autosuggest_textarea.js10++--------
1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/app/javascript/mastodon/components/autosuggest_textarea.js b/app/javascript/mastodon/components/autosuggest_textarea.js @@ -124,13 +124,7 @@ class AutosuggestTextarea extends ImmutablePureComponent { } onBlur = () => { - // If we hide the suggestions immediately, then this will prevent the - // onClick for the suggestions themselves from firing. - // Setting a short window for that to take place before hiding the - // suggestions ensures that can't happen. - setTimeout(() => { - this.setState({ suggestionsHidden: true }); - }, 100); + this.setState({ suggestionsHidden: true }); } onSuggestionClick = (e) => { @@ -191,7 +185,7 @@ class AutosuggestTextarea extends ImmutablePureComponent { key={suggestion} data-index={suggestion} className={`autosuggest-textarea__suggestions__item ${i === selectedSuggestion ? 'selected' : ''}`} - onClick={this.onSuggestionClick} + onMouseDown={this.onSuggestionClick} > <AutosuggestAccountContainer id={suggestion} /> </div>