mastofe

commit: 37b043d4478fb195d0c2ae7fe7ba0207ce63032d
parent: 36579bac88b88b7bb916ce7bcc56152427156a26
Author: abcang <abcang1015@gmail.com>
Date:   Sun, 11 Mar 2018 01:44:26 +0900

Improve performance of account_media_status_ids (#6729)


Diffstat:
M
app/controllers/api/v1/accounts/statuses_controller.rb
8
+++++++-

1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/app/controllers/api/v1/accounts/statuses_controller.rb b/app/controllers/api/v1/accounts/statuses_controller.rb
@@ -51,7 +51,13 @@ class Api::V1::Accounts::StatusesController < Api::BaseController
   end
 
   def account_media_status_ids
-    @account.media_attachments.attached.reorder(nil).select(:status_id).distinct
+    # `SELECT DISTINCT id, updated_at` is too slow, so pluck ids at first, and then select id, updated_at with ids.
+    # Also, Avoid getting slow by not narrowing down by `statuses.account_id`.
+    # When narrowing down by `statuses.account_id`, `index_statuses_20180106` will be used
+    # and the table will be joined by `Merge Semi Join`, so the query will be slow.
+    Status.joins(:media_attachments).merge(@account.media_attachments).permitted_for(@account, current_account)
+          .paginate_by_max_id(limit_param(DEFAULT_STATUSES_LIMIT), params[:max_id], params[:since_id])
+          .reorder(id: :desc).distinct(:id).pluck(:id)
   end
 
   def pinned_scope