mastofe

commit: 2edfdab6e6d70598a19d59f8a2f47ecae8add243
parent: 4edf9d849f5241aed42042577c889549a5b6beaa
Author: Yamagishi Kazutoshi <ykzts@desire.sh>
Date:   Fri, 18 Aug 2017 17:42:59 +0900

Don't send Link header when don't know prev and next links (#4633)


Diffstat:
M
app/controllers/api/base_controller.rb
2
+-
M
spec/controllers/api/v1/favourites_controller_spec.rb
3
+--

2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/app/controllers/api/base_controller.rb b/app/controllers/api/base_controller.rb
@@ -43,7 +43,7 @@ class Api::BaseController < ApplicationController
     links = []
     links << [next_path, [%w(rel next)]] if next_path
     links << [prev_path, [%w(rel prev)]] if prev_path
-    response.headers['Link'] = LinkHeader.new(links)
+    response.headers['Link'] = LinkHeader.new(links) unless links.empty?
   end
 
   def limit_param(default_limit)
diff --git a/spec/controllers/api/v1/favourites_controller_spec.rb b/spec/controllers/api/v1/favourites_controller_spec.rb
@@ -70,8 +70,7 @@ RSpec.describe Api::V1::FavouritesController, type: :controller do
         it 'does not add pagination headers if not necessary' do
           get :index
 
-          expect(response.headers['Link'].find_link(['rel', 'next'])).to eq nil
-          expect(response.headers['Link'].find_link(['rel', 'prev'])).to eq nil
+          expect(response.headers['Link']).to eq nil
         end
       end
     end