mastofe

commit: 19257d91bf1e613b48a7ac9de7ce6933405c9657
parent: fe180f18ff38a01007842ccff293a84a63336aae
Author: Renato "Lond" Cerqueira <renato@lond.com.br>
Date:   Tue, 12 Dec 2017 15:12:09 +0100

Return false if object does not respond to url (#5988)

Avoid error when the service returns a mostly valid oembed, but has no
url in it, causing a MethodError: undefined method `url'
for #<OEmbed::Response::Photo:0x000056505def9620>
Diffstat:
M
app/services/fetch_link_card_service.rb
1
+

1 file changed, 1 insertion(+), 0 deletions(-)
diff --git a/app/services/fetch_link_card_service.rb b/app/services/fetch_link_card_service.rb
@@ -87,6 +87,7 @@ class FetchLinkCardService < BaseService
     when 'link'
       @card.image = URI.parse(response.thumbnail_url) if response.respond_to?(:thumbnail_url)
     when 'photo'
+      return false unless response.respond_to?(:url)
       @card.embed_url = response.url
       @card.width     = response.width.presence  || 0
       @card.height    = response.height.presence || 0