mastofe

commit: 0cbf3a146f5ac22a2187d8daa271e20b4e2d9b13
parent: 8132cf8153e45aa75333c5bfd636141e1792bd50
Author: Eugen Rochko <eugen@zeonfederated.com>
Date:   Fri, 17 Feb 2017 01:34:37 +0100

Speed up/optimize loading of statuses, context and cards by not re-fetching what is already loaded

Diffstat:
M
app/assets/javascripts/components/actions/cards.jsx
4
++++
M
app/assets/javascripts/components/actions/statuses.jsx
9
+++++++--

2 files changed, 11 insertions(+), 2 deletions(-)
diff --git a/app/assets/javascripts/components/actions/cards.jsx b/app/assets/javascripts/components/actions/cards.jsx
@@ -6,6 +6,10 @@ export const STATUS_CARD_FETCH_FAIL    = 'STATUS_CARD_FETCH_FAIL';
 
 export function fetchStatusCard(id) {
   return (dispatch, getState) => {
+    if (getState().getIn(['cards', id], null) !== null) {
+      return;
+    }
+
     dispatch(fetchStatusCardRequest(id));
 
     api(getState).get(`/api/v1/statuses/${id}/card`).then(response => {
diff --git a/app/assets/javascripts/components/actions/statuses.jsx b/app/assets/javascripts/components/actions/statuses.jsx
@@ -27,12 +27,17 @@ export function fetchStatus(id) {
   return (dispatch, getState) => {
     const skipLoading = getState().getIn(['statuses', id], null) !== null;
 
+    dispatch(fetchContext(id));
+    dispatch(fetchStatusCard(id));
+
+    if (skipLoading) {
+      return;
+    }
+
     dispatch(fetchStatusRequest(id, skipLoading));
 
     api(getState).get(`/api/v1/statuses/${id}`).then(response => {
       dispatch(fetchStatusSuccess(response.data, skipLoading));
-      dispatch(fetchContext(id));
-      dispatch(fetchStatusCard(id));
     }).catch(error => {
       dispatch(fetchStatusFail(id, error, skipLoading));
     });