utils

commit: a9479eff02132795fb498bf868beaf9dd738eaca
parent dfa239ea7f66e04e3b5018c49cf546549fb456a2
Author: Haelwenn (lanodan) Monnier <contact@hacktivis.me>
Date:   Tue, 15 Feb 2022 01:07:42 +0100

test_all.sh: Fix shellcheck warnings

Diffstat:
M
Makefile
2
+-
M
test_all.sh
8
++++----

2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/Makefile b/Makefile
@@ -5,7 +5,7 @@ all:
 	cd sbin ; $(MAKE)
 
 test: all
-	$(SHELLCHECK) ./configure
+	$(SHELLCHECK) ./configure test_all.sh
 	SHELLCHECK=${SHELLCHECK} ./test-bin/shellcheck
 	POSIX_ME_HARDER=1 POSIXLY_CORRECT=1 kyua test || (kyua report --verbose; false)
 	cd bin ; $(MAKE) test
diff --git a/test_all.sh b/test_all.sh
@@ -8,7 +8,7 @@ export CFLAGS="-O2 -g2 -Wall -Wextra -Werror=all"
 
 for make in gmake bmake pmake
 do
-	if grep '#define\W__GLIBC__' /usr/include/features.h
+	if grep -q '#define\W__GLIBC__' /usr/include/features.h
 	then
 		compilers="tcc gcc clang"
 		for cc in cproc pcc
@@ -23,7 +23,7 @@ do
 
 	for cc in $compilers
 	do
-		if command -v $cc && command -v $make
+		if command -v "$cc" && command -v "$make"
 		then
 			echo "CC=${cc} time ${make} clean"
 			if CC=${cc} time ${make} clean; then
@@ -35,7 +35,7 @@ do
 				exit 1
 			fi
 
-			echo "CC=${cc} time ${make} ${makeflags} all"
+			echo "CC=${cc} time ${make} all"
 			if CC=${cc} time ${make} -j1 all
 			then
 				echo "TEST-ALL: CC=${cc} ${make} all: OK"
@@ -46,7 +46,7 @@ do
 				continue
 			fi
 
-			echo "CC=${cc} time ${make} ${makeflags} test"
+			echo "CC=${cc} time ${make} test"
 			if CC=${cc} time ${make} -j1 test
 			then
 				echo "TEST-ALL: CC=${cc} ${make} test: OK"