logo

oasis

Own branch of Oasis Linux (upstream: <https://git.sr.ht/~mcf/oasis/>) git clone https://anongit.hacktivis.me/git/oasis.git

0019-Fix-CVE-2016-9844-buffer-overflow-in-zipinfo.patch (1306B)


  1. From 7e0435546230ecebe3bfe1ac27eb0186c702c509 Mon Sep 17 00:00:00 2001
  2. From: "Steven M. Schweda" <sms@antinode.info>
  3. Date: Sat, 15 Jun 2019 18:13:11 -0700
  4. Subject: [PATCH] Fix CVE-2016-9844, buffer overflow in zipinfo
  5. ---
  6. zipinfo.c | 13 ++++++++++++-
  7. 1 file changed, 12 insertions(+), 1 deletion(-)
  8. diff --git a/zipinfo.c b/zipinfo.c
  9. index 5e77018..0be3e5b 100644
  10. --- a/zipinfo.c
  11. +++ b/zipinfo.c
  12. @@ -1921,7 +1921,18 @@ static int zi_short(__G) /* return PK-type error code */
  13. ush dnum=(ush)((G.crec.general_purpose_bit_flag>>1) & 3);
  14. methbuf[3] = dtype[dnum];
  15. } else if (methnum >= NUM_METHODS) { /* unknown */
  16. - sprintf(&methbuf[1], "%03u", G.crec.compression_method);
  17. + /* 2016-12-05 SMS.
  18. + * https://launchpad.net/bugs/1643750
  19. + * Unexpectedly large compression methods overflow
  20. + * &methbuf[]. Use the old, three-digit decimal format
  21. + * for values which fit. Otherwise, sacrifice the "u",
  22. + * and use four-digit hexadecimal.
  23. + */
  24. + if (G.crec.compression_method <= 999) {
  25. + sprintf( &methbuf[ 1], "%03u", G.crec.compression_method);
  26. + } else {
  27. + sprintf( &methbuf[ 0], "%04X", G.crec.compression_method);
  28. + }
  29. }
  30. for (k = 0; k < 15; ++k)
  31. --
  32. 2.20.1