logo

oasis

Own branch of Oasis Linux (upstream: <https://git.sr.ht/~mcf/oasis/>) git clone https://anongit.hacktivis.me/git/oasis.git

0018-Fix-CVE-2014-9913-buffer-overflow-in-unzip.patch (1457B)


  1. From 27b0cd89656d39266da7dcab7eb1812dcfc34192 Mon Sep 17 00:00:00 2001
  2. From: "Steven M. Schweda" <sms@antinode.info>
  3. Date: Sat, 15 Jun 2019 18:13:11 -0700
  4. Subject: [PATCH] Fix CVE-2014-9913, buffer overflow in unzip
  5. ---
  6. list.c | 13 ++++++++++++-
  7. 1 file changed, 12 insertions(+), 1 deletion(-)
  8. diff --git a/list.c b/list.c
  9. index 5de41e5..e488109 100644
  10. --- a/list.c
  11. +++ b/list.c
  12. @@ -339,7 +339,18 @@ int list_files(__G) /* return PK-type error code */
  13. G.crec.compression_method == ENHDEFLATED) {
  14. methbuf[5] = dtype[(G.crec.general_purpose_bit_flag>>1) & 3];
  15. } else if (methnum >= NUM_METHODS) {
  16. - sprintf(&methbuf[4], "%03u", G.crec.compression_method);
  17. + /* 2013-02-26 SMS.
  18. + * http://sourceforge.net/p/infozip/bugs/27/ CVE-2014-9913.
  19. + * Unexpectedly large compression methods overflow
  20. + * &methbuf[]. Use the old, three-digit decimal format
  21. + * for values which fit. Otherwise, sacrifice the
  22. + * colon, and use four-digit hexadecimal.
  23. + */
  24. + if (G.crec.compression_method <= 999) {
  25. + sprintf( &methbuf[ 4], "%03u", G.crec.compression_method);
  26. + } else {
  27. + sprintf( &methbuf[ 3], "%04X", G.crec.compression_method);
  28. + }
  29. }
  30. #if 0 /* GRR/Euro: add this? */
  31. --
  32. 2.20.1